lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240924123144.GH4029621@kernel.org>
Date: Tue, 24 Sep 2024 13:31:44 +0100
From: Simon Horman <horms@...nel.org>
To: Shen Lichuan <shenlichuan@...o.com>
Cc: isdn@...ux-pingi.de, quic_jjohnson@...cinc.com, kuba@...nel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	opensource.kernel@...o.com
Subject: Re: [PATCH v1] isdn: mISDN: Correct typos in multiple comments
 across various files

On Tue, Sep 24, 2024 at 05:11:17PM +0800, Shen Lichuan wrote:
> Fixed some confusing spelling errors that were currently identified,
> the details are as follows:
> 
> -in the code comments:
> 	netjet.c: 382:		overun		==> overrun
> 	w6692.c: 776:		reqest		==> request
> 	dsp_audio.c: 208:	tabels		==> tables
> 	dsp_cmx.c: 575:		suppoted	==> supported
> 	hwchannel.c: 369:	imediately	==> immediately
> 
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
>  drivers/isdn/hardware/mISDN/netjet.c | 2 +-
>  drivers/isdn/hardware/mISDN/w6692.c  | 2 +-
>  drivers/isdn/mISDN/dsp_audio.c       | 2 +-
>  drivers/isdn/mISDN/dsp_cmx.c         | 2 +-
>  drivers/isdn/mISDN/hwchannel.c       | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)

Hi Shen,

Thanks for your patch.

Running codespell over the files modified by this patch indicates
that the following spelling errors remain, I'd suggest addressing them
too.

drivers/isdn/hardware/mISDN/w6692.c:861: oscilator ==> oscillator
drivers/isdn/mISDN/dsp_audio.c:181: aplitude ==> amplitude, aptitude
drivers/isdn/mISDN/dsp_cmx.c:2: conferrencing ==> conferencing

Or perhaps consider extending spelling fixes to cover all files under
drivers/isdn/mISDN and drivers/isdn/hardware/mISDN. There seem to be a lot,
so if so might consider one patch per sub-directory or something like that
to break things up a bit.


On process:

It is my understanding that patches for drivers/isdn are handled by
the netdev maintainers. That is non-bug fixes go into net-next,
and bug fixes go into net. In this case it is not a but fix, so
the patch should be targeted at net-next, like this.

	Subject: [PATCH net-next v2] ...

Currently net-next is closed for the v6.12 merge window.
It should reopen after v6.12-rc1 has been released,
which I expect to take place a little under a week from now.

Other than RFCs, patches shouldn't be posted for net-next while it is
closed. So please repost your patch, or post an updated patch once
it reopens.

You can find out more about the development process for the Networking
subsystem here: https://docs.kernel.org/process/maintainer-netdev.html

...

-- 
pw-bot: defer

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ