[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a6b9a56f-4bf0-44f3-bfca-f75bab1c1ca9@quicinc.com>
Date: Tue, 24 Sep 2024 08:18:09 -0700
From: "Abhishek Chauhan (ABC)" <quic_abchauha@...cinc.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
CC: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet
<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni
<pabeni@...hat.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Andrew Halaney <ahalaney@...hat.com>,
"Andrew
Lunn" <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
"Bartosz
Golaszewski" <bartosz.golaszewski@...aro.org>,
"linux-tegra@...r.kernel.org"
<linux-tegra@...r.kernel.org>,
Brad Griffis <bgriffis@...dia.com>,
"Vladimir
Oltean" <vladimir.oltean@....com>,
Jon Hunter <jonathanh@...dia.com>,
"Maxime
Chevallier" <maxime.chevallier@...tlin.com>,
<kernel@...cinc.com>
Subject: Re: [PATCH net v2] net: phy: aquantia: Introduce custom get_features
On 9/24/2024 1:36 AM, Russell King (Oracle) wrote:
> On Mon, Sep 23, 2024 at 10:52:51PM -0700, Abhishek Chauhan wrote:
>> +static void aqr_supported_speed(struct phy_device *phydev, u32 max_speed)
>> +{
>> + __ETHTOOL_DECLARE_LINK_MODE_MASK(supported) = { 0, };
>> +
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_Pause_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_TP_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_10baseT_Half_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_10baseT_Full_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT, supported);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, supported);
>
> Maybe consider using:
>
> linkmode_copy(supported, phy_gbit_features);
>
> It shouldn't be necessary to set the two pause bits. You also won't need
> the initialiser.
Noted ! Thanks Russell.
>
Powered by blists - more mailing lists