netdev - Re: [PATCH 2/4] selftests: rds: add include.sh to EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6a24c2862535e00c9294e6c7d1f90354c992d72.camel@oracle.com>
Date: Tue, 24 Sep 2024 15:25:24 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "kees@...nel.org"
	<kees@...nel.org>,
        "javier.carrasco.cruz@...il.com"
	<javier.carrasco.cruz@...il.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>
CC: "rds-devel@....oracle.com" <rds-devel@....oracle.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: Re: [PATCH 2/4] selftests: rds: add include.sh to EXTRA_CLEAN

On Tue, 2024-09-24 at 14:49 +0200, Javier Carrasco wrote:
> The include.sh file is generated when building the net/rds selftests,
> but there is no rule to delete it with the clean target. Add the file
> to
> EXTRA_CLEAN in order to remove it when required.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Ok, looks good. Thanks for catching this
Reviewed-by: Allison Henderson <allison.henderson@...cle.com>

> ---
>  tools/testing/selftests/net/rds/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/rds/Makefile
> b/tools/testing/selftests/net/rds/Makefile
> index da9714bc7aad..0b697669ea51 100644
> --- a/tools/testing/selftests/net/rds/Makefile
> +++ b/tools/testing/selftests/net/rds/Makefile
> @@ -7,6 +7,6 @@ TEST_PROGS := run.sh \
>         include.sh \
>         test.py
>  
> -EXTRA_CLEAN := /tmp/rds_logs
> +EXTRA_CLEAN := /tmp/rds_logs include.sh
>  
>  include ../../lib.mk
>