Message-ID: <20240925.jah8aibekaH3@digikod.net>
Date: Wed, 25 Sep 2024 20:31:15 +0200
From: Mickaël Salaün <mic@...ikod.net>
To: Mikhail Ivanov <ivanov.mikhail1@...wei-partners.com>
Cc: Günther Noack <gnoack@...gle.com>, 
	willemdebruijn.kernel@...il.com, gnoack3000@...il.com, linux-security-module@...r.kernel.org, 
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org, yusongping@...wei.com, 
	artem.kuzin@...wei.com, konstantin.meskhidze@...wei.com, 
	Matthieu Buffet <matthieu@...fet.re>
Subject: Re: [RFC PATCH v2 02/12] landlock: Add hook on socket creation

On Fri, Jun 07, 2024 at 05:45:46PM +0300, Mikhail Ivanov wrote:
> 6/5/2024 8:27 PM, Günther Noack wrote:
> > Hello!
> > 
> > On Thu, May 30, 2024 at 03:20:21PM +0300, Mikhail Ivanov wrote:
> > > 5/27/2024 11:48 AM, Günther Noack wrote:
> > > > On Fri, May 24, 2024 at 05:30:05PM +0800, Mikhail Ivanov wrote:
> > > > > Add hook to security_socket_post_create(), which checks whether the socket
> > > > > type and family are allowed by domain. Hook is called after initializing
> > > > > the socket in the network stack to not wrongfully return EACCES for a
> > > > > family-type pair, which is considered invalid by the protocol.
> > > > > 
> > > > > Signed-off-by: Mikhail Ivanov <ivanov.mikhail1@...wei-partners.com>
> > > > 
> > > > ## Some observations that *do not* need to be addressed in this commit, IMHO:
> > > > 
> > > > get_raw_handled_socket_accesses, get_current_socket_domain and
> > > > current_check_access_socket are based on the similarly-named functions from
> > > > net.c (and fs.c), and it makes sense to stay consistent with these.
> > > > 
> > > > There are some possible refactorings that could maybe be applied to that code,
> > > > but given that the same ones would apply to net.c as well, it's probably best to
> > > > address these separately.
> > > > 
> > > >     * Should get_raw_handled_socket_accesses be inlined
> > > It's a fairly simple and compact function, so compiler should inline it
> > > without any problems. Mickaël was against optional inlines [1].
> > > 
> > > [1] https://lore.kernel.org/linux-security-module/5c6c99f7-4218-1f79-477e-5d943c9809fd@digikod.net/
> > 
> > Sorry for the confusion -- what I meant was not "should we add the inline
> > keyword", but I meant "should we remove that function and place its
> > implementation in the place where we are currently calling it"?
> 
> Oh, I got it, thanks!
> It will be great to find a way how to generalize this helpers. But if
> we won't come up with some good design, it will be really better to
> simply inline them. I added a mark about this in code refactoring issue
> [1].

Making such simple helper more generic might not be worth it.  Landlock
doesn't handle a lot of different "objects".

> 
> [1] https://github.com/landlock-lsm/linux/issues/34
> 
> > 
> > 
> > > >     * Does the WARN_ON_ONCE(dom->num_layers < 1) check have the right return code?
> > > 
> > > Looks like a rudimental check. `dom` is always NULL when `num_layers`< 1
> > > (see get_*_domain functions).
> > 
> > What I found irritating about it is that with 0 layers (= no Landlock policy was
> > ever enabled), you would logically assume that we return a success?  But then I
> > realized that this code was copied verbatim from other places in fs.c and net.c,
> > and it is actually checking for an internal inconsistency that is never supposed
> > to happen.  If we were to actually hit that case at some point, we have probably
> > stumbled over our own feet and it might be better to not permit anything.
> 
> This check is probably really useful for validating code changes.

Correct, this is mostly useful for developers when changing the kernel
code.  We'll remove this kind of check when we'll have a proper struct
landlock_domain. ;)

> 
> > 
> > 
> > > >     * Can we refactor out commonalities (probably not worth it right now though)?
> > > 
> > > I had a few ideas about refactoring commonalities, as currently landlock
> > > has several repetitive patterns in the code. But solution requires a
> > > good design and a separate patch. Probably it's worth opening an issue
> > > on github. WDYT?
> > 
> > Absolutely, please do open one.  In my mind, patches in C which might not get
> > accepted are an expensive way to iterate on such ideas, and it might make sense
> > to collect some refactoring approaches on a bug or the mailing list before
> > jumping into the implementation.
> > 
> > (You might want to keep an eye on https://github.com/landlock-lsm/linux/issues/1
> > as well, which is about some ideas to refactor Landlock's internal data
> > structures.)
> 
> Thank you! Discussing refactoring ideas before actually implementing
> them sounds really great. We can collect multiple ideas, discuss them
> and implement a single dedicated patchlist.
> 
> Issue: https://github.com/landlock-lsm/linux/issues/34.

Yes, we are continuing the discussion there.

> 
> > 
> > 
> > > > ## The only actionable feedback that I have that is specific to this commit is:
> > > > 
> > > > In the past, we have introduced new (non-test) Landlock functionality in a
> > > > single commit -- that way, we have no "loose ends" in the code between these two
> > > > commits, and that simplifies it for people who want to patch your feature onto
> > > > other kernel trees.  (e.g. I think we should maybe merge commit 01/12 and 02/12
> > > > into a single commit.)  WDYT?
> > > 
> > > Yeah, this two should be merged and tests commits as well. I just wanted
> > > to do this in one of the latest patch versions to simplify code review.
> > 
> > That sounds good, thanks!
> > 
> > —Günther
> 

Powered by blists - more mailing lists