netdev - Re: [PATCH] Fix issue related with assigning two diffrent vids to the same interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240925191537.GX4029621@kernel.org>
Date: Wed, 25 Sep 2024 20:15:37 +0100
From: Simon Horman <horms@...nel.org>
To: Kacper Ludwinski <kacper@...winski.dev>
Cc: davem@...emloft.net, kuba@...nel.org, vladimir.oltean@....com,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] Fix issue related with assigning two diffrent vids to
 the same interface.

On Wed, Sep 25, 2024 at 02:05:39PM +0900, Kacper Ludwinski wrote:
> Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
> Signed-off-by: Kacper Ludwinski <kacper@...winski.dev>
> ---
>  tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

...

Hi Kacper,

Thanks for your patch.

Some feedback in process:

* Please do not post updated versions of patches within 24h of each
  other.

* Please do post new versions of patches in new threads,
  with appropriate versions in the subject (v2 in this case).
  And some text under the scissors ('---') describing that the change is.
  b4 will handle this for you.

* Please include some text in the commit message,
  in this case describing the problem that is being resolved.

* Please tag patches for Networking as being targeted at either
  the net or net-next trees.

  Subject: [PATCH net v2] ...

* Please refer to git history and include an appropriate prefix
  in the subject of the patch. In this case it looks like
  it should be 'selftests: forwarding:'

  Subject: [PATCH net v2] selftests: forwarding: ...

* Please consider reading the netdev maintainers process guide
  https://docs.kernel.org/process/maintainer-netdev.html

Lastly, there is a spelling error in the subject.
checkpatch.pl --codespell flagged this.

-- 
pw-bot: changes-requested