netdev - Re: [PATCH] xfrm: add SA information to the offloaded packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240925081924.GB967758@unreal>
Date: Wed, 25 Sep 2024 11:19:24 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Steffen Klassert <steffen.klassert@...unet.com>
Cc: Feng Wang <wangfe@...gle.com>, netdev@...r.kernel.org,
	antony.antony@...unet.com
Subject: Re: [PATCH] xfrm: add SA information to the offloaded packet

On Tue, Sep 24, 2024 at 08:10:41PM +0200, Steffen Klassert wrote:
> Please don't top post!
> 
> On Tue, Sep 24, 2024 at 10:57:12AM -0700, Feng Wang wrote:
> > Hi Steffen,
> > 
> > The easiest thing would be to upstream your driver, that is the
> > prefered way and would just end this discussion.
> > 
> > I will try to upstream the xfrm interface id handling code to
> > netdevsim, thus it will have an in-driver implementation.
> 
> Netdevsim is just the second best option and still might
> lead to discussion.

netdevsim should come with relevant selftests, otherwise this
new feature won't be tested properly. We can't rely on someone
out-of-tree to test it.

> 
> Upstream the google driver that actually uses it, this _is_
> the prefered way.

+1

>