netdev - Re: [PATCH] cfg80211: Convert WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84336e03a2634f0d1305cfbdfbae516a7a67364a.camel@sipsolutions.net>
Date: Thu, 26 Sep 2024 21:51:45 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Vladislav Efanov <VEfanov@...ras.ru>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, "John W. Linville" <linville@...driver.com>,
 linux-wireless@...r.kernel.org,  netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,  lvc-project@...uxtesting.org
Subject: Re: [PATCH] cfg80211: Convert WARN_ON() to warning message

On Thu, 2024-09-26 at 16:34 +0300, Vladislav Efanov wrote:
> syzkaller got the following warning:
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 9992 at net/wireless/ibss.c:36 __cfg80211_ibss
> 
> This warning is the result of the race condition between the following
> events:
> 
> event1                          event2                      event3
> __ieee80211_sta_join_ibss()        |                          |
> creates new cgf80211_bss           |                          |
> structure.                         |                          |
> Calls cfg80211_ibss_joined()       |                          |
> which will scheduled               |                          |
> new event_work.                    |                          |
>                          ieee80211_ibss_disconnect()          |
>                          is called due to connection          |
>                          dropped/ibss leaves to               |
>                          remove cfg80211_bss structure.       |
>                                                 event_work starts.
>                                           __cfg80211_ibss_joined()
> 

Seems almost better though to solve it by removing the pending work when
disconnecting?

johannes