netdev - Re: [PATCH net] selftests/net: packetdrill: increase timing tolerance in debug mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd29c5e5-219d-44ad-8403-1abe4015f75c@redhat.com>
Date: Thu, 26 Sep 2024 11:03:38 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Stanislav Fomichev <stfomichev@...il.com>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
 edumazet@...gle.com, sdf@...ichev.me, matttbe@...nel.org,
 linux-kselftest@...r.kernel.org, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] selftests/net: packetdrill: increase timing tolerance
 in debug mode

On 9/19/24 23:04, Stanislav Fomichev wrote:
> On 09/19, Willem de Bruijn wrote:
>> From: Willem de Bruijn <willemb@...gle.com>
>>
>> Some packetdrill tests are flaky in debug mode. As discussed, increase
>> tolerance.
>>
>> We have been doing this for debug builds outside ksft too.
>>
>> Previous setting was 10000. A manual 50 runs in virtme-ng showed two
>> failures that needed 12000. To be on the safe side, Increase to 14000.
>>
>> Link: https://lore.kernel.org/netdev/Zuhhe4-MQHd3EkfN@mini-arch/
>> Fixes: 1e42f73fd3c2 ("selftests/net: packetdrill: import tcp/zerocopy")
>> Reported-by: Stanislav Fomichev <sdf@...ichev.me>
>> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> 
> Acked-by: Stanislav Fomichev <sdf@...ichev.me>
> 
> Thanks! Should probably go to net-next though? (Not sure what's
> the bar for selftests fixes for 'net')

FTR, we want this kind of fixes in net, to reach self-test stability in 
both trees ASAP.

Cheers,

Paolo