netdev - Re: [PATCH net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99cb11c8d4cb2f9c64aabc400c1e2c39d9b1e004.camel@siemens.com>
Date: Thu, 26 Sep 2024 10:23:54 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "rogerq@...nel.org" <rogerq@...nel.org>, "dan.carpenter@...aro.org"
	<dan.carpenter@...aro.org>
CC: "c-vankar@...com" <c-vankar@...com>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "jpanis@...libre.com" <jpanis@...libre.com>,
	"grygorii.strashko@...com" <grygorii.strashko@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kuba@...nel.org" <kuba@...nel.org>, "horms@...nel.org" <horms@...nel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: ethernet: ti: am65-cpsw: Fix forever loop in
 cleanup code

Hi Dan!

On Thu, 2024-09-26 at 12:50 +0300, Dan Carpenter wrote:
> This error handling has a typo.  It should i++ instead of i--.  In the
> original code the error handling will loop until it crashes.
> 
> Fixes: da70d184a8c3 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks for fixing this!
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

> ---
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index cbe99017cbfa..d253727b160f 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -763,7 +763,7 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
> 	k3_udma_glue_disable_rx_chn(rx_chn->rx_chn);
>  
>  fail_rx:
> -	for (i = 0; i < common->rx_ch_num_flows; i--)
> +	for (i = 0; i < common->rx_ch_num_flows; i++)
>  		k3_udma_glue_reset_rx_chn(rx_chn->rx_chn, i, &rx_chn->flows[i],
>  					  am65_cpsw_nuss_rx_cleanup, 0);
>  

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com