netdev - Re: [PATCH net v2] selftests: forwarding: no_forwarding: Fix issue related with assigning two different vids to the same interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <765e0a55-8bb6-45a7-a32e-73b40f92f7dd@linuxfoundation.org>
Date: Fri, 27 Sep 2024 10:16:32 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Kacper Ludwiński <kac.ludwinski@...tonmail.com>,
 "davem@...emloft.net" <davem@...emloft.net>
Cc: "kuba@...nel.org" <kuba@...nel.org>,
 "vladimir.oltean@....com" <vladimir.oltean@....com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "petrm@...dia.com"
 <petrm@...dia.com>, "horms@...nel.org" <horms@...nel.org>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "shuah@...nel.org" <shuah@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH net v2] selftests: forwarding: no_forwarding: Fix issue
 related with assigning two different vids to the same interface.

On 9/27/24 01:03, Kacper Ludwiński wrote:
> Fix typo.

Remove the above line. It gives the impression that this is
a minor spelling fix when it is not. It is fixing a problem
that prevents the test from running correctly.

> Currently, the second bridge command overwrites the first one.
> Fix this by adding this VID to the interface behind $swp2.
> 
> Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
> Signed-off-by: Kacper Ludwinski <kacper@...winski.dev>
> ---
>   tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh
> index 9e677aa64a06..694ece9ba3a7 100755
> --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh
> +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh
> @@ -202,7 +202,7 @@ one_bridge_two_pvids()
>   	ip link set $swp2 master br0
> 
>   	bridge vlan add dev $swp1 vid 1 pvid untagged
> -	bridge vlan add dev $swp1 vid 2 pvid untagged
> +	bridge vlan add dev $swp2 vid 2 pvid untagged
> 
>   	run_test "Switch ports in VLAN-aware bridge with different PVIDs"
> 
> --
> 2.43.0
> 

With the above change:

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah