netdev - Re: [PATCH v2 19/25] netfs: Speed up buffered reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2668612.1727471502@warthog.procyon.org.uk>
Date: Fri, 27 Sep 2024 22:11:42 +0100
From: David Howells <dhowells@...hat.com>
To: Eduard Zingerman <eddyz87@...il.com>
Cc: dhowells@...hat.com, Manu Bretelle <chantr4@...il.com>,
    asmadeus@...ewreck.org, ceph-devel@...r.kernel.org,
    christian@...uner.io, ericvh@...nel.org, hsiangkao@...ux.alibaba.com,
    idryomov@...il.com, jlayton@...nel.org,
    linux-afs@...ts.infradead.org, linux-cifs@...r.kernel.org,
    linux-erofs@...ts.ozlabs.org, linux-fsdevel@...r.kernel.org,
    linux-kernel@...r.kernel.org, linux-mm@...ck.org,
    linux-nfs@...r.kernel.org, marc.dionne@...istor.com,
    netdev@...r.kernel.org, netfs@...ts.linux.dev, pc@...guebit.com,
    smfrench@...il.com, sprasad@...rosoft.com, tom@...pey.com,
    v9fs@...ts.linux.dev, willy@...radead.org
Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading

Eduard Zingerman <eddyz87@...il.com> wrote:

> On Fri, 2024-09-27 at 21:50 +0100, David Howells wrote:
> > Is it possible for you to turn on some tracepoints and access the traces?
> > Granted, you probably need to do the enablement during boot.
> 
> Yes, sure, tell me what you need.

If you look here:

	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes

you can see some patches I've added.  If you can try this branch or cherry
pick:

	netfs: Fix write oops in generic/346 (9p) and generic/074 (cifs)
	netfs: Advance iterator correctly rather than jumping it
	netfs: Use a folio_queue allocation and free functions
	netfs: Add a tracepoint to log the lifespan of folio_queue structs

And then turn on the following "netfs" tracepoints:

	read,sreq,rreq,failure,write,write_iter,folio,folioq,progress,donate

which can be done by:

	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_read/enable
	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_rreq/enable
	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_sreq/enable
	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_failure/enable
	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_write/enable
	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_write_iter/enable
	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_folio/enable
	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_folioq/enable
	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_progress/enable
	echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_donate/enable

or through trace-cmd.

> Alternatively I can pack this thing in a dockerfile, so that you would
> be able to reproduce locally (but that would have to wait till my evening).

I don't have Docker set up, so I'm not sure how easy that would be for me to
use.

Thanks,
David