netdev - Re: [PATCH net-next v7 04/25] ovpn: add basic netlink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80eee015-49a1-4f89-a688-e035b518409d@openvpn.net>
Date: Fri, 27 Sep 2024 09:52:04 +0200
From: Antonio Quartulli <antonio@...nvpn.net>
To: Donald Hunter <donald.hunter@...il.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, pabeni@...hat.com,
 ryazanov.s.a@...il.com, edumazet@...gle.com, andrew@...n.ch,
 sd@...asysnail.net
Subject: Re: [PATCH net-next v7 04/25] ovpn: add basic netlink support

On 26/09/2024 17:06, Donald Hunter wrote:
> On Wed, 25 Sept 2024 at 12:36, Antonio Quartulli <antonio@...nvpn.net> wrote:
>>
>> Donald,
>>
>> I see most (if not all) modules have named ops dev-del/add/get, while in
>> ovpn I am going with new/del-dev (action and object are inverted).
>>
>> Do you think it'd make sense to change all the op names to follow the
>> convention used by the other modules?
> 
> It's a good question. I'm not sure there's much consistency for either format:
> 
> Total ops: 231
> Starts with (new|get|del): 51
> Ends with (new|get|del): 63
> Exactly (new|get|del): 11
> 
> For the legacy and raw specs that I have written, I followed whatever
> convention was used for the enums in the UAPI, e.g. getroute from
> RTM_GETROUTE. The newer genetlink specs like netdev.yaml mostly favour
> the dev-get form so maybe that's the convention we should try to
> establish going forward?

If netdev went with that format, I presume that's where the preference 
is, therefore I'll follow that one.

I'll modify the op names then.

Thanks a lot.

Cheers,

> 
> Cheers,
> Donald.

-- 
Antonio Quartulli
OpenVPN Inc.