netdev - Re: [PATCH net v3] net: phy: qt2025: Fix warning: unused import DeviceId

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D0E9079F-5872-4A37-AF88-799EC318FE0D@kloenk.dev>
Date: Fri, 27 Sep 2024 10:46:34 +0200
From: Fiona Behrens <me@...enk.dev>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, andrew@...n.ch,
 tmgross@...ch.edu, aliceryhl@...gle.com, hkallweit1@...il.com,
 linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net v3] net: phy: qt2025: Fix warning: unused import
 DeviceId



On 26 Sep 2024, at 14:14, FUJITA Tomonori wrote:

> Fix the following warning when the driver is compiled as built-in:
>
>       warning: unused import: `DeviceId`
>       --> drivers/net/phy/qt2025.rs:18:5
>       |
>    18 |     DeviceId, Driver,
>       |     ^^^^^^^^
>       |
>       = note: `#[warn(unused_imports)]` on by default
>
> device_table in module_phy_driver macro is defined only when the
> driver is built as a module. Use phy::DeviceId in the macro instead of
> importing `DeviceId` since `phy` is always used.
>
> Fixes: fd3eaad826da ("net: phy: add Applied Micro QT2025 PHY driver")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409190717.i135rfVo-lkp@intel.com/
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> Reviewed-by: Trevor Gross <tmgross@...ch.edu>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>
> ---

Reviewed-by: Fiona Behrens <me@...enk.dev>