netdev - Re: ICE + XSK ZC - page faults on 6.1 LTS when process exits?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <30bd4ecb-961b-404a-ac3d-9c25c8269e4d@leemhuis.info>
Date: Fri, 27 Sep 2024 13:32:42 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Alasdair McWilliam <alasdair.mcwilliam@...look.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: Magnus Karlsson <magnus.karlsson@...il.com>,
 "xdp-newbies@...r.kernel.org" <xdp-newbies@...r.kernel.org>,
 Linux kernel regressions list <regressions@...ts.linux.dev>,
 Larysa Zaremba <larysa.zaremba@...el.com>,
 Jacob Keller <jacob.e.keller@...el.com>, netdev <netdev@...r.kernel.org>
Subject: Re: ICE + XSK ZC - page faults on 6.1 LTS when process exits?

[CCing a few people that were involved in mainlining the culprit
(8adbf5a42341f6e ("ice: remove af_xdp_zc_qps bitmap") in case they want
to provide advice]

On 13.09.24 17:54, Alasdair McWilliam wrote:
> On 05/09/2024 13:50, Alasdair McWilliam wrote:
> 
>>> We've been working recently on somewhat related issues and it looks like
>>> not every commit from [0] has been backported.
>>>
>>> $ git log --oneline v6.1.103..v6.1.104 drivers/net/ethernet/intel/ice/
>>> 5a80b682e3e1 ice: add missing WRITE_ONCE when clearing ice_rx_ring::xdp_prog
>>> 8782f0fcb19d ice: replace synchronize_rcu with synchronize_net
>>> 15115033f056 ice: don't busy wait for Rx queue disable in ice_qp_dis()
>>> 3dbc58774e58 ice: respect netif readiness in AF_XDP ZC related ndo's
>>>
>>> can you apply the rest of it on top of 6.1.107 and see the result?
>
>> The first one I've attempted doesn't apply cleanly to 6.1.107.
>>
>> Eg: d59227179949 ("ice: modify error handling when setting XSK pool in
>> ndo_bpf"). The above looks to have been based on code from around 6.8 or
>> 6.9 where the makeup of routines like ice_qp_ena() has changed. Looks
>> like this happened around a292ba981324 ("ice: make ice_vsi_cfg_txq()
>> static").
>>
>> Should I try and apply a292ba981324 as well?
> 
> I just wondered if there was perhaps any further feedback on the above.

Hmmm. No reply afaics -- but that's how it is sometimes with
stable/longterm kernels series, as mainline developers are not required
to participate in their development.

Still it would be good to fix the problem. So unless the developers come
up with plan, it might be best to just revert a62c50545b4d in 6.1.y;
guess asking Greg to do so might be best way ahead unless some solutions
comes into sight within a few days.

Ciao, Thorsten

#regzbot poke