netdev - Re: [PATCH bpf-next v2 1/2] libbpf: do not resolve size on duplicate FUNCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MW4PR11MB8289A6D1FC8B6823A67583BED7752@MW4PR11MB8289.namprd11.prod.outlook.com>
Date: Mon, 30 Sep 2024 01:45:17 +0800
From: Eric Long <i@...k3r.moe>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: bpf <bpf@...r.kernel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 1/2] libbpf: do not resolve size on duplicate
 FUNCs

On 30/09/2024 00:32, Alexei Starovoitov wrote:
> On Sun, Sep 29, 2024 at 2:31 AM Eric Long via B4 Relay
> <devnull+i.hack3r.moe@...nel.org> wrote:
> 
> Looks like a hack to me.
> 
> In the test you're using:
> void *bpf_cast_to_kern_ctx(void *obj) __ksym;
> 
> but __weak is missing.
> Is that the reason you're hitting this issue?
> 

No. libbpf still returns -EINVAL (from the same path) even if the 
prototype is marked __weak, when the patch is not applied.

(Sorry for the off-list reply)