netdev - Re: [net-next PATCH 07/11] net: ravb: Simplify UDP TX checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fb6f818-e818-4ba2-b1a9-e4468d4496aa@omp.ru>
Date: Mon, 30 Sep 2024 22:39:11 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Paul Barker <paul@...rker.dev>, "David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>
CC: Paul Barker <paul.barker.ct@...renesas.com>, Geert Uytterhoeven
	<geert+renesas@...der.be>, Niklas Söderlund
	<niklas.soderlund+renesas@...natech.se>, Biju Das
	<biju.das.jz@...renesas.com>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, <netdev@...r.kernel.org>,
	<linux-renesas-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [net-next PATCH 07/11] net: ravb: Simplify UDP TX checksum
 offload

On 9/30/24 19:08, Paul Barker wrote:

> From: Paul Barker <paul.barker.ct@...renesas.com>
> 
> The GbEth IP will pass through a null UDP checksum without asserting any

   s/null/zero/, perhaps?

> error flags so we do not need to resort to software checksum calculation
> in this case.
> 
> Signed-off-by: Paul Barker <paul.barker.ct@...renesas.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 9350ca10ab22..ae0268f2eb04 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -2075,20 +2075,12 @@ static bool ravb_can_tx_csum_gbeth(struct sk_buff *skb)
>  
>  	switch (ip->protocol) {
>  	case IPPROTO_TCP:
> -		break;
>  	case IPPROTO_UDP:
> -		/* If the checksum value in the UDP header field is 0, TOE does
> -		 * not calculate checksum for UDP part of this frame as it is
> -		 * optional function as per standards.
> -		 */
> -		if (udp_hdr(skb)->check == 0)
> -			return false;
> -		break;
> +		return true;
> +

   No need for an empty line here, it's not used elsewhere in the *switch*
statements...

>  	default:
>  		return false;
>  	}

[...]

MBR, Sergey