netdev - Re: [PATCH] dt-bindings: net: can: atmel: Convert to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddf6d8cf-8d35-4dcf-b156-d6e221d0ddf8@microchip.com>
Date: Mon, 30 Sep 2024 04:07:08 +0000
From: <Charan.Pedumuru@...rochip.com>
To: <mkl@...gutronix.de>
CC: <mailhol.vincent@...adoo.fr>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
	<claudiu.beznea@...on.dev>, <linux-can@...r.kernel.org>,
	<netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: net: can: atmel: Convert to json schema

On 23/09/24 16:27, Marc Kleine-Budde wrote:
> On 20.09.2024 04:51:57,Charan.Pedumuru@...rochip.com  wrote:
>>>> +allOf:
>>>> +  - $ref: can-controller.yaml#
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            enum:
>>>> +              - microchip,sam9x60-can
>>>> +    then:
>>>> +      required:
>>>> +        - compatible
>>>> +        - reg
>>>> +        - interrupts
>>>> +        - clocks
>>>> +        - clock-names
>>> AFAICS clock-names is required for all compatibles.
>> In our case only sam9x60 is using clock-names property.
> No, the driver uses "clk_get(&pdev->dev, "can_clk")", so this property
> is mandatory.
Yes, what you said was correct, it was our mistake. I will remove the if 
statements and make
clocks and clock-names as default required properties. I will fix this 
in next revision.

>
> regards,
> Marc
>
> -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | 
> https://www.pengutronix.de | Vertretung Nürnberg | Phone: 
> +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: 
> +49-5121-206917-9 |


-- 
Best Regards,
Charan.