netdev - Re: [PATCH net 02/10] ice: Fix improper handling of refcount in ice_dpll_init_rclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f28f2b21-a829-48c6-a122-4850b7276b8a@linux.dev>
Date: Tue, 1 Oct 2024 12:26:47 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 netdev@...r.kernel.org
Cc: Gui-Dong Han <hanguidong02@...look.com>, baijiaju1990@...il.com,
 arkadiusz.kubalewski@...el.com, jiri@...nulli.us, stable@...r.kernel.org,
 Simon Horman <horms@...nel.org>,
 Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net 02/10] ice: Fix improper handling of refcount in
 ice_dpll_init_rclk_pins()

On 30/09/2024 23:35, Tony Nguyen wrote:
> From: Gui-Dong Han <hanguidong02@...look.com>
> 
> This patch addresses a reference count handling issue in the
> ice_dpll_init_rclk_pins() function. The function calls ice_dpll_get_pins(),
> which increments the reference count of the relevant resources. However,
> if the condition WARN_ON((!vsi || !vsi->netdev)) is met, the function
> currently returns an error without properly releasing the resources
> acquired by ice_dpll_get_pins(), leading to a reference count leak.
> 
> To resolve this, the check has been moved to the top of the function. This
> ensures that the function verifies the state before any resources are
> acquired, avoiding the need for additional resource management in the
> error path.
> 
> This bug was identified by an experimental static analysis tool developed
> by our team. The tool specializes in analyzing reference count operations
> and detecting potential issues where resources are not properly managed.
> In this case, the tool flagged the missing release operation as a
> potential problem, which led to the development of this patch.
> 
> Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu")
> Cc: stable@...r.kernel.org
> Signed-off-by: Gui-Dong Han <hanguidong02@...look.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_dpll.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c
> index cd95705d1e7f..8b6dc4d54fdc 100644
> --- a/drivers/net/ethernet/intel/ice/ice_dpll.c
> +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c
> @@ -1843,6 +1843,8 @@ ice_dpll_init_rclk_pins(struct ice_pf *pf, struct ice_dpll_pin *pin,
>   	struct dpll_pin *parent;
>   	int ret, i;
>   
> +	if (WARN_ON((!vsi || !vsi->netdev)))
> +		return -EINVAL;
>   	ret = ice_dpll_get_pins(pf, pin, start_idx, ICE_DPLL_RCLK_NUM_PER_PF,
>   				pf->dplls.clock_id);
>   	if (ret)
> @@ -1858,8 +1860,6 @@ ice_dpll_init_rclk_pins(struct ice_pf *pf, struct ice_dpll_pin *pin,
>   		if (ret)
>   			goto unregister_pins;
>   	}
> -	if (WARN_ON((!vsi || !vsi->netdev)))
> -		return -EINVAL;
>   	dpll_netdev_pin_set(vsi->netdev, pf->dplls.rclk.pin);
>   
>   	return 0;

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>