netdev - Re: [PATCH net v4] selftests: net: no_forwarding: fix VID for $swp2 in one_bridge_two

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241001121021.jczfi6s4xrjy5mvn@skbuf>
Date: Tue, 1 Oct 2024 15:10:21 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Kacper Ludwinski <kac.ludwinski@...oud.com>
Cc: davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
	pabeni@...hat.com, petrm@...dia.com, horms@...nel.org,
	edumazet@...gle.com, shuah@...nel.org,
	Hangbin Liu <liuhangbin@...il.com>,
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH net v4] selftests: net: no_forwarding: fix VID for $swp2
 in one_bridge_two_pvids() test

On Mon, Sep 30, 2024 at 03:35:43PM +0900, Kacper Ludwinski wrote:
> This typo has an impact on results of the test results,
> potentially leading to wrong conclusions regarding
> the functionality of a network device.

Did you test this? You are effectively introducing a new test.
Could you include the test result in the commit message, please?
Also, "results of the test results" doesn't sound too good.