netdev - Re: [PATCH net 2/3] net: dsa: mv88e6xxx: read cycle counter period from hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410011105.XXvEbI6k-lkp@intel.com>
Date: Tue, 1 Oct 2024 12:17:55 +0800
From: kernel test robot <lkp@...el.com>
To: Shenghao Yang <me@...nghaoyang.info>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Shenghao Yang <me@...nghaoyang.info>,
	f.fainelli@...il.com, olteanv@...il.com, pavana.sharma@...i.com,
	ashkan.boldaji@...i.com, kabel@...nel.org, andrew@...n.ch
Subject: Re: [PATCH net 2/3] net: dsa: mv88e6xxx: read cycle counter period
 from hardware

Hi Shenghao,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Shenghao-Yang/net-dsa-mv88e6xxx-group-cycle-counter-coefficients/20240929-182245
base:   net/main
patch link:    https://lore.kernel.org/r/20240929101949.723658-3-me%40shenghaoyang.info
patch subject: [PATCH net 2/3] net: dsa: mv88e6xxx: read cycle counter period from hardware
config: sparc64-randconfig-r133-20240930 (https://download.01.org/0day-ci/archive/20241001/202410011105.XXvEbI6k-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.1.0
reproduce: (https://download.01.org/0day-ci/archive/20241001/202410011105.XXvEbI6k-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410011105.XXvEbI6k-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/net/dsa/mv88e6xxx/ptp.c:35:34: sparse: sparse: symbol 'mv88e6xxx_cc_10ns_coeffs' was not declared. Should it be static?
>> drivers/net/dsa/mv88e6xxx/ptp.c:49:34: sparse: sparse: symbol 'mv88e6xxx_cc_8ns_coeffs' was not declared. Should it be static?

vim +/mv88e6xxx_cc_10ns_coeffs +35 drivers/net/dsa/mv88e6xxx/ptp.c

    27	
    28	/* Family MV88E6250:
    29	 * Raw timestamps are in units of 10-ns clock periods.
    30	 *
    31	 * clkadj = scaled_ppm * 10*2^28 / (10^6 * 2^16)
    32	 * simplifies to
    33	 * clkadj = scaled_ppm * 2^7 / 5^5
    34	 */
  > 35	const struct mv88e6xxx_cc_coeffs mv88e6xxx_cc_10ns_coeffs = {
    36		.cc_shift = 28,
    37		.cc_mult = 10 << 28,
    38		.cc_mult_num = 1 << 7,
    39		.cc_mult_dem = 3125ULL,
    40	};
    41	
    42	/* Other families:
    43	 * Raw timestamps are in units of 8-ns clock periods.
    44	 *
    45	 * clkadj = scaled_ppm * 8*2^28 / (10^6 * 2^16)
    46	 * simplifies to
    47	 * clkadj = scaled_ppm * 2^9 / 5^6
    48	 */
  > 49	const struct mv88e6xxx_cc_coeffs mv88e6xxx_cc_8ns_coeffs = {
    50		.cc_shift = 28,
    51		.cc_mult = 8 << 28,
    52		.cc_mult_num = 1 << 9,
    53		.cc_mult_dem = 15625ULL
    54	};
    55	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki