netdev - Re: [PATCH net-next 03/15] net: sparx5: rename *spx5 to *sparx5 in a few places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fc3df5c-6160-4eb6-b2fe-5efa99337e6f@intel.com>
Date: Tue, 1 Oct 2024 10:54:01 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Daniel Machon <daniel.machon@...rochip.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Lars Povlsen
	<lars.povlsen@...rochip.com>, Steen Hegelund <Steen.Hegelund@...rochip.com>,
	<horatiu.vultur@...rochip.com>, <jensemil.schulzostergaard@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>, Richard Cochran <richardcochran@...il.com>,
	<horms@...nel.org>, <justinstitt@...gle.com>, <gal@...dia.com>,
	<aakash.r.menon@...il.com>
CC: <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 03/15] net: sparx5: rename *spx5 to *sparx5 in a
 few places



On 10/1/2024 6:50 AM, Daniel Machon wrote:
> In preparation for lan969x, we need to handle platform specific
> constants (which will be added in a subsequent patch). These constants
> will be accessed through a macro that requires the *sparx5 context
> pointer to be called exactly that.

Another place where macros implicitly assume some local variable? Not a
big fan of that, though I suppose it does leave shorter code.

No issue with the renames though.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>