netdev - Re: [PATCH v1 net-next 5/5] ipv4: Trigger check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241001205551.13350-1-kuniyu@amazon.com>
Date: Tue, 1 Oct 2024 13:55:51 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <kuba@...nel.org>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH v1 net-next 5/5] ipv4: Trigger check_lifetime() only when necessary.

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue, 1 Oct 2024 11:27:18 +0200
> On Tue, Oct 1, 2024 at 4:51 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
> >
> > DHCP is unlikely to be used in non-root network namespaces, and GC is
> > unnecessary in such cases.
> >
> > Let's count the number of non-permanent IPv4 addresses and schedule GC
> > only when the count is not zero.
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> 
> I find this a bit distracting honestly.
> 
> Lets focus on RTNL first, there are already a lot of reviews.

Sure, will keep this in a local post-conversion branch.

I'll post v2 with patch 1-4 + tags and Sparse warning (__force u32) fixed.

Thanks!