netdev - Re: [PATCHv2 net-next 03/10] net: lantiq_etop: use devm for register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3776b850-ac0b-4ffc-ac36-2aad2209535c@lunn.ch>
Date: Wed, 2 Oct 2024 00:48:23 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org,
	olek2@...pl, shannon.nelson@....com
Subject: Re: [PATCHv2 net-next 03/10] net: lantiq_etop: use devm for
 register_netdev

On Tue, Oct 01, 2024 at 11:46:00AM -0700, Rosen Penev wrote:
> This is the last to be created and so must be the first to be freed.
> Simpler to avoid by using devm.

Actually, devm does not enforce that. All it enforces is that
resources controlled via devm are released in reverse order. Things
not using devm will be release first by explicit code.

The only reason devm is safe is that the core ensures the interface is
closed. So the order probably does not matter.

    Andrew

---
pw-bot: cr