netdev - Re: [PATCHv2 net-next 01/10] net: lantiq_etop: use netif_receive_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKxU2N-b2SsORrMbXnf-ezqR2TG+pyuMtEx5+wdX7z07oA8iqQ@mail.gmail.com>
Date: Tue, 1 Oct 2024 16:39:52 -0700
From: Rosen Penev <rosenp@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org, olek2@...pl, 
	shannon.nelson@....com
Subject: Re: [PATCHv2 net-next 01/10] net: lantiq_etop: use netif_receive_skb_list

On Tue, Oct 1, 2024 at 3:40 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Tue, Oct 01, 2024 at 11:45:58AM -0700, Rosen Penev wrote:
> > Improves cache efficiency by batching rx skb processing. Small
> > performance improvement on RX.
>
> Benchmark numbers would be good.
>
> >
> > Signed-off-by: Rosen Penev <rosenp@...il.com>
> > Reviewed-by: Shannon Nelson <shannon.nelson@....com>
> > ---
> >  drivers/net/ethernet/lantiq_etop.c | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> > index 3c289bfe0a09..94b37c12f3f7 100644
> > --- a/drivers/net/ethernet/lantiq_etop.c
> > +++ b/drivers/net/ethernet/lantiq_etop.c
> > @@ -122,8 +122,7 @@ ltq_etop_alloc_skb(struct ltq_etop_chan *ch)
> >       return 0;
> >  }
> >
> > -static void
> > -ltq_etop_hw_receive(struct ltq_etop_chan *ch)
> > +static void ltq_etop_hw_receive(struct ltq_etop_chan *ch, struct list_head *lh)
>
> Please don't put the return type on the same line. If you look at this
> driver, it is the coding style to always have it on a separate
> line. You broken the coding style.
I'm using git clang-format HEAD~1 on my commits. Something to improve I guess.
>
>
>     Andrew
>
> ---
> pw-bot: cr
>