netdev - Re: [PATCH] net: stmmac: dwmac-tegra: Fix link bring-up sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7485182b-797d-4476-b65c-7b1311d99442@redhat.com>
Date: Tue, 1 Oct 2024 10:43:46 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jon Hunter <jonathanh@...dia.com>,
 Thierry Reding <thierry.reding@...il.com>,
 Paritosh Dixit <paritoshd@...dia.com>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Bhadram Varka <vbhadram@...dia.com>,
 Revanth Kumar Uppala <ruppala@...dia.com>, netdev@...r.kernel.org,
 linux-tegra@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-tegra: Fix link bring-up sequence

On 9/27/24 17:28, Jon Hunter wrote:
> On 25/09/2024 14:40, Thierry Reding wrote:
>> All in all, I wonder if we wouldn't be better off increasing these
>> delays to the point where we can use usleep_range(). That will make
>> the overall lane bringup slightly longer (though it should still be well
>> below 1ms, so hardly noticeable from a user's perspective) but has the
>> benefit of not blocking the CPU during this time.
> 
> Yes we can certainly increase the delay and use usleep_range() as you
> prefer. Let us know what you would recommend here.

Use of usleep_range() would be definitely preferrable.

Additionally, please replace c99 comments '// ...' with ansi ones:
'/* ... */'

Thanks,

Paolo