netdev - Re: [PATCH net-next v4 06/12] net: vxlan: make vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241002133543.GW1310185@kernel.org>
Date: Wed, 2 Oct 2024 14:35:43 +0100
From: Simon Horman <horms@...nel.org>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: idosch@...dia.com, kuba@...nel.org, aleksander.lobakin@...el.com,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	dsahern@...nel.org, dongml2@...natelecom.cn, amcohen@...dia.com,
	gnault@...hat.com, bpoirier@...dia.com, b.galvani@...il.com,
	razor@...ckwall.org, petrm@...dia.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 06/12] net: vxlan: make vxlan_snoop() return
 drop reasons

On Tue, Oct 01, 2024 at 03:32:19PM +0800, Menglong Dong wrote:
> Change the return type of vxlan_snoop() from bool to enum
> skb_drop_reason. In this commit, two drop reasons are introduced:
> 
>   SKB_DROP_REASON_VXLAN_INVALID_SMAC
>   SKB_DROP_REASON_VXLAN_ENTRY_EXISTS
> 
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> ---
> v4:
> - rename SKB_DROP_REASON_VXLAN_INVALID_SMAC to
>   SKB_DROP_REASON_MAC_INVALID_SOURCE

super-nit: SKB_DROP_REASON_VXLAN_INVALID_SMAC was renamed in the code below
           but not the patch description above

In any case, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>