netdev - Re: [PATCH net-next 1/2] net: add IFLA_MAX_PACING_OFFLOAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241002064735.5b1127ab@kernel.org>
Date: Wed, 2 Oct 2024 06:47:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Willem de Bruijn <willemb@...gle.com>, Jeffrey Ji
 <jeffreyji@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 1/2] net: add IFLA_MAX_PACING_OFFLOAD_HORIZON
 device attribute

On Mon, 30 Sep 2024 15:23:03 +0000 Eric Dumazet wrote:
> @@ -1867,6 +1868,9 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb,
>  			READ_ONCE(dev->tso_max_size)) ||
>  	    nla_put_u32(skb, IFLA_TSO_MAX_SEGS,
>  			READ_ONCE(dev->tso_max_segs)) ||
> +	    nla_put_u64_64bit(skb, IFLA_MAX_PACING_OFFLOAD_HORIZON,
> +			      READ_ONCE(dev->max_pacing_offload_horizon),
> +			      IFLA_PAD) ||

nla_put_uint() ?

>  #ifdef CONFIG_RPS
>  	    nla_put_u32(skb, IFLA_NUM_RX_QUEUES,
>  			READ_ONCE(dev->num_rx_queues)) ||
> @@ -2030,6 +2034,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
>  	[IFLA_ALLMULTI]		= { .type = NLA_REJECT },
>  	[IFLA_GSO_IPV4_MAX_SIZE]	= { .type = NLA_U32 },
>  	[IFLA_GRO_IPV4_MAX_SIZE]	= { .type = NLA_U32 },
> +	[IFLA_MAX_PACING_OFFLOAD_HORIZON]= { .type = NLA_REJECT },

Let's do this instead ?

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index f0a520987085..a68de5c15b46 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1975,6 +1975,7 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb,
 }
 
 static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
+       [IFLA_UNSPEC]           = { .strict_start_type = IFLA_DPLL_PIN },
        [IFLA_IFNAME]           = { .type = NLA_STRING, .len = IFNAMSIZ-1 },
        [IFLA_ADDRESS]          = { .type = NLA_BINARY, .len = MAX_ADDR_LEN },
        [IFLA_BROADCAST]        = { .type = NLA_BINARY, .len = MAX_ADDR_LEN },