netdev - Re: [PATCH net-next 06/15] net: sparx5: add constants to match data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241002073352.43a3afb5@kernel.org>
Date: Wed, 2 Oct 2024 07:33:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Lars Povlsen
 <lars.povlsen@...rochip.com>, Steen Hegelund
 <Steen.Hegelund@...rochip.com>, <horatiu.vultur@...rochip.com>,
 <jensemil.schulzostergaard@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
 Richard Cochran <richardcochran@...il.com>, <horms@...nel.org>,
 <justinstitt@...gle.com>, <gal@...dia.com>, <aakash.r.menon@...il.com>,
 <jacob.e.keller@...el.com>, <netdev@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 06/15] net: sparx5: add constants to match data

On Wed, 2 Oct 2024 13:31:32 +0000 Daniel Machon wrote:
> By "type the code out" - are you saying that we should not be using a macro
> for accessing the const at all? and rather just:
> 
>     struct sparx5_consts *consts = sparx5->data->consts;
>     consts->some_var

This.

> or pass in the sparx5 pointer to the macro too, which was the concert that
> Jacob raised.

The implicit arguments are part of the ugliness, and should also go
away. But in this case the entire macro should go.