netdev - Re: [PATCH net] net: phy: dp83869: fix memory corruption when enabling fiber

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2595456f-c55a-4de6-be2d-8d544f453b18@lunn.ch>
Date: Wed, 2 Oct 2024 19:01:19 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ingo van Lil <inguin@....de>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Dan Murphy <dmurphy@...com>,
	Alexander Sverdlin <alexander.sverdlin@...mens.com>
Subject: Re: [PATCH net] net: phy: dp83869: fix memory corruption when
 enabling fiber

On Wed, Oct 02, 2024 at 06:18:07PM +0200, Ingo van Lil wrote:
> When configuring the fiber port, the DP83869 PHY driver incorrectly
> calls linkmode_set_bit() with a bit mask (1 << 10) rather than a bit
> number (10). This corrupts some other memory location -- in case of
> arm64 the priv pointer in the same structure.
> 
> Since the advertising flags are updated from supported at the end of the
> function the incorrect line isn't needed at all and can be removed.
> 
> Fixes: a29de52ba2a1 ("net: dp83869: Add ability to advertise Fiber connection")
> Signed-off-by: Ingo van Lil <inguin@....de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew