netdev - [PATCH net-next 0/3] tcp: add fast path in timer handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241002173042.917928-1-edumazet@google.com>
Date: Wed,  2 Oct 2024 17:30:39 +0000
From: Eric Dumazet <edumazet@...gle.com>
To: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>
Cc: Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com, 
	Eric Dumazet <edumazet@...gle.com>
Subject: [PATCH net-next 0/3] tcp: add fast path in timer handlers

As mentioned in Netconf 2024:

TCP retransmit and delack timers are not stopped from
inet_csk_clear_xmit_timer() because we do not define
INET_CSK_CLEAR_TIMERS.

Enabling INET_CSK_CLEAR_TIMERS leads to lower performance,
mainly because del_timer() and mod_timer() happen from
different cpus quite often.

What we can do instead is to add fast paths to tcp_write_timer()
and tcp_delack_timer() to avoid socket spinlock acquisition.

Eric Dumazet (3):
  tcp: annotate data-races around icsk->icsk_pending
  tcp: add a fast path in tcp_write_timer()
  tcp: add a fast path in tcp_delack_timer()

 include/net/inet_connection_sock.h |  9 +++++----
 net/ipv4/inet_connection_sock.c    |  6 ++++--
 net/ipv4/inet_diag.c               | 10 ++++++----
 net/ipv4/tcp_ipv4.c                | 10 ++++++----
 net/ipv4/tcp_output.c              |  7 ++++---
 net/ipv4/tcp_timer.c               | 18 ++++++++++++++++--
 net/ipv6/tcp_ipv6.c                | 10 ++++++----
 net/mptcp/protocol.c               |  3 ++-
 8 files changed, 49 insertions(+), 24 deletions(-)

-- 
2.47.0.rc0.187.ge670bccf7e-goog