netdev - Re: [PATCH net-next 0/8] net: smsc911x: clean up with devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKxU2N9aHtfjdk3XYvOXxX3LRwbv+WFfe9omXmxLTBRVTDsRqg@mail.gmail.com>
Date: Wed, 2 Oct 2024 12:17:52 -0700
From: Rosen Penev <rosenp@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, andrew@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com, linux-kernel@...r.kernel.org, 
	steve.glendinning@...well.net
Subject: Re: [PATCH net-next 0/8] net: smsc911x: clean up with devm

On Wed, Oct 2, 2024 at 5:32 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 30 Sep 2024 15:40:48 -0700 Rosen Penev wrote:
> > It happens to fix missing frees, especially with mdiobus functions.
>
> Do you have the real hardware and have you tested this on it?
>
> Please always include such information in the commit message.
> Random conversions to devm are discouraged in networking.
That's unfortunate.