[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241002091539.73177c18@fedora.home>
Date: Wed, 2 Oct 2024 09:15:39 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, andrew@...n.ch, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
linux-kernel@...r.kernel.org, claudiu.manoil@....com
Subject: Re: [PATCH net-next 1/6] net: gianfar: use devm_alloc_etherdev_mqs
On Tue, 1 Oct 2024 14:21:59 -0700
Rosen Penev <rosenp@...il.com> wrote:
> There seems to be a mistake here. There's a num_rx_qs variable that is not
> being passed to the allocation function. The mq variant just calls mqs
> with the last parameter of the former duplicated to the last parameter
> of the latter. That's fine if they match. Not sure they do.
As far as I can tell, both queue numbers used during the netdev alloc
are always the same, so this looks good to me.
Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
Thanks,
Maxime
Powered by blists - more mailing lists