netdev - Re: [PATCH iwl-net 1/5] ice: Fix E825 initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c0d64bd-3730-c0e7-b0af-5929aa4fbf9d@intel.com>
Date: Wed, 2 Oct 2024 15:00:26 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Karol Kolacinski <karol.kolacinski@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, <przemyslaw.kitszel@...el.com>, "Arkadiusz
 Kubalewski" <arkadiusz.kubalewski@...el.com>
Subject: Re: [PATCH iwl-net 1/5] ice: Fix E825 initialization



On 9/30/2024 5:08 AM, Karol Kolacinski wrote:
> Current implementation checks revision of all PHYs on all PFs, which is
> incorrect and may result in initialization failure. Check only the
> revision of the current PHY.

This patch seems to be doing too many things. This part sounds like a patch.

> E825 does not need to modify sideband queue access, because those values
> are properly set by the firmware on init.
> Remove PF_SB_REM_DEV_CTL modification.

This seems like another patch. Also, this doesn't sound like a bug so it 
should go via -next.

> Configure synchronization delay for E825 product to ensure proper PHY
> timers initialization on SYNC command.

This sounds like another patch.

Thanks,
Tony