netdev - Re: [PATCH net-next 3/6] net: gianfar: allocate queues with devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241002092509.1b56b470@fedora.home>
Date: Wed, 2 Oct 2024 09:25:09 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, andrew@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 linux-kernel@...r.kernel.org, claudiu.manoil@....com
Subject: Re: [PATCH net-next 3/6] net: gianfar: allocate queues with devm

On Tue,  1 Oct 2024 14:22:01 -0700
Rosen Penev <rosenp@...il.com> wrote:

> There seems to be a mistake here where free_tx_queue is called on
> failure. Just let devm deal with it.

Good catch, this looks good to me.

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Maxime