netdev - Re: [RFC PATCH v2] Simply enable one to write code like:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bf84a9c-f274-4b92-8545-7e1418c00ffa@intel.com>
Date: Wed, 2 Oct 2024 10:07:33 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: <linux-kernel@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>,
	<amadeuszx.slawinski@...ux.intel.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, <nex.sw.ncis.osdt.itp.upstreaming@...el.com>,
	<netdev@...r.kernel.org>, Markus Elfring <Markus.Elfring@....de>, "Dmitry
 Torokhov" <dmitry.torokhov@...il.com>, Dan Carpenter
	<dan.carpenter@...aro.org>
Subject: Re: [RFC PATCH v2] Simply enable one to write code like:

On 10/1/24 17:09, Andy Shevchenko wrote:
> On Tue, Oct 01, 2024 at 04:57:18PM +0200, Przemek Kitszel wrote:
> 
> ...
> 
>> NAKed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> 
> And still NAKed.
> 
>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>> ---
>> Andy believes that this change is completely wrong C, the reasons
>> (that I disagree with of course, are in v1, below the commit message).
> 
> Have you retested the macro expansion for this version?

yeah, I basically work with the expanded version, still linear
expansion, just ~dozen bytes more than v1

> 
> ...
> 
>>    */
>>   
>> +
> 
> Too many blank lines.

thanks!

> 
>> +#define DEFINE_CLASS_IS_CONDITIONAL(_name, _is_cond)	\
>> +static __maybe_unused const bool class_##_name##_is_conditional = _is_cond
> 
> ...
> 
>> +	DEFINE_CLASS_IS_CONDITIONAL(_name, 0); \
> 
> Here and everywhere else, boolean has values true and false.

sure, thanks