[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241003112629.GL1310185@kernel.org>
Date: Thu, 3 Oct 2024 12:26:29 +0100
From: Simon Horman <horms@...nel.org>
To: Gilad Naaman <gnaaman@...venets.com>
Cc: netdev <netdev@...r.kernel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 2/2] Create netdev->neighbour association
On Tue, Oct 01, 2024 at 05:09:57AM +0000, Gilad Naaman wrote:
> Create a mapping between a netdev and its neighoburs,
> allowing for much cheaper flushes.
>
> Signed-off-by: Gilad Naaman <gnaaman@...venets.com>
Hi Gilad,
As per my comment on patch 1/2, This is not a full review, but rather some
feedback to take into account once a proper review arrives.
...
> diff --git a/Documentation/networking/net_cachelines/net_device.rst b/Documentation/networking/net_cachelines/net_device.rst
...
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
...
> @@ -2399,6 +2400,8 @@ struct net_device {
> /** @irq_moder: dim parameters used if IS_ENABLED(CONFIG_DIMLIB). */
> struct dim_irq_moder *irq_moder;
>
> + struct hlist_head neighbours[NEIGH_NR_TABLES];
> +
Please add an entry for neighbours in the Kernel doc for this
structure, which is immediately above it.
This is flagged by ./scripts/kernel-doc -none, and W=1 allmodconfig builds.
> u8 priv[] ____cacheline_aligned
> __counted_by(priv_len);
> } ____cacheline_aligned;
...
Powered by blists - more mailing lists