netdev - Re: [PATCH net-next v4 0/2] ethtool: Add support for writing firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241003135354.GP1310185@kernel.org>
Date: Thu, 3 Oct 2024 14:53:54 +0100
From: Simon Horman <horms@...nel.org>
To: Danielle Ratson <danieller@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, yuehaibing@...wei.com,
	linux-kernel@...r.kernel.org, petrm@...dia.com
Subject: Re: [PATCH net-next v4 0/2] ethtool: Add support for writing firmware

On Tue, Oct 01, 2024 at 03:41:48PM +0300, Danielle Ratson wrote:
> In the CMIS specification for pluggable modules, LPL (Local Payload) and
> EPL (Extended Payload) are two types of data payloads used for managing
> various functions and features of the module.
> 
> EPL payloads are used for more complex and extensive management functions
> that require a larger amount of data, so writing firmware blocks using EPL
> is much more efficient.
> 
> Currently, only LPL payload is supported for writing firmware blocks to
> the module.
> 
> Add support for writing firmware block using EPL payload, both to support
> modules that support only EPL write mechanism, and to optimize the flashing
> process of modules that support LPL and EPL.
> 
> Running the flashing command on the same sample module using EPL vs. LPL
> showed an improvement of 84%.
> 
> Patchset overview:
> Patch #1: preparations
> Patch #2: Add EPL support
> 
> v4: Resending the right version after wrong v3.

Thanks, this one looks good :)

> 
> v2:
> 	* Fix the commit meassges to align the cover letter about the
> 	  right meaning of LPL and EPL.
> 	Patch #2:
> 	* Initialize the variable 'bytes_written' before the first
> 	  iteration.
> 
> Danielle Ratson (2):
>   net: ethtool: Add new parameters and a function to support EPL
>   net: ethtool: Add support for writing firmware blocks using EPL
>     payload
> 
>  net/ethtool/cmis.h           |  16 ++++--
>  net/ethtool/cmis_cdb.c       |  94 +++++++++++++++++++++++++-----
>  net/ethtool/cmis_fw_update.c | 108 +++++++++++++++++++++++++++++------
>  3 files changed, 184 insertions(+), 34 deletions(-)
> 
> -- 
> 2.45.0
>