netdev - Re: [PATCH net-next v2 05/10] lib: packing: duplicate pack() and unpack() implementations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241003151156.oxsf33omtxqci5jw@skbuf>
Date: Thu, 3 Oct 2024 18:11:56 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH net-next v2 05/10] lib: packing: duplicate pack() and
 unpack() implementations

On Wed, Oct 02, 2024 at 02:51:54PM -0700, Jacob Keller wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> packing() is now used in some hot paths, and it would be good to get rid
> of some ifs and buts that depend on "op", to speed things up a little bit.
> 
> With the main implementations now taking size_t endbit, we no longer
> have to check for negative values. Update the local integer variables to
> also be size_t to match.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>