netdev - Re: [PATCH net-next v2 05/12] selftests: ncdevmem: Remove default arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zv7IFJqBbASyl26L@mini-arch>
Date: Thu, 3 Oct 2024 09:36:36 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com
Subject: Re: [PATCH net-next v2 05/12] selftests: ncdevmem: Remove default
 arguments

On 10/02, Mina Almasry wrote:
> On Mon, Sep 30, 2024 at 10:18 AM Stanislav Fomichev <sdf@...ichev.me> wrote:
> >
> > To make it clear what's required and what's not. Also, some of the
> > values don't seem like a good defaults; for example eth1.
> >
> > Cc: Mina Almasry <almasrymina@...gle.com>
> > Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>
> > ---
> >  tools/testing/selftests/net/ncdevmem.c | 34 +++++++++-----------------
> >  1 file changed, 12 insertions(+), 22 deletions(-)
> >
> > diff --git a/tools/testing/selftests/net/ncdevmem.c b/tools/testing/selftests/net/ncdevmem.c
> > index 699692fdfd7d..bf446d74a4f0 100644
> > --- a/tools/testing/selftests/net/ncdevmem.c
> > +++ b/tools/testing/selftests/net/ncdevmem.c
> > @@ -42,32 +42,13 @@
> >  #define MSG_SOCK_DEVMEM 0x2000000
> >  #endif
> >
> > -/*
> > - * tcpdevmem netcat. Works similarly to netcat but does device memory TCP
> > - * instead of regular TCP. Uses udmabuf to mock a dmabuf provider.
> > - *
> > - * Usage:
> > - *
> > - *     On server:
> > - *     ncdevmem -s <server IP> -c <client IP> -f eth1 -l -p 5201 -v 7
> > - *
> 
> No need to remove this documentation I think. This is useful since we
> don't have a proper docs anywhere.
> 
> Please instead update the args in the above line, if they need
> updating, but looks like it's already correct even after this change.

The client needs '-s' part. That's why I removed it - most likely
will tend to go stale and we now have the invocation example in the
selftest. But if you want to keep it, how about I move it to the
top of the file and cleanup a bit? Will do for the next iteration..