netdev - Re: [PATCH net-next v2 05/12] selftests: ncdevmem: Remove default arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izPbGa7v9UfcMNXhwLQ6z2dNth92x6MF7zwgUijziK0U-g@mail.gmail.com>
Date: Wed, 2 Oct 2024 23:59:27 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next v2 05/12] selftests: ncdevmem: Remove default arguments

On Mon, Sep 30, 2024 at 10:18 AM Stanislav Fomichev <sdf@...ichev.me> wrote:
>
> To make it clear what's required and what's not. Also, some of the
> values don't seem like a good defaults; for example eth1.
>
> Cc: Mina Almasry <almasrymina@...gle.com>
> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>
> ---
>  tools/testing/selftests/net/ncdevmem.c | 34 +++++++++-----------------
>  1 file changed, 12 insertions(+), 22 deletions(-)
>
> diff --git a/tools/testing/selftests/net/ncdevmem.c b/tools/testing/selftests/net/ncdevmem.c
> index 699692fdfd7d..bf446d74a4f0 100644
> --- a/tools/testing/selftests/net/ncdevmem.c
> +++ b/tools/testing/selftests/net/ncdevmem.c
> @@ -42,32 +42,13 @@
>  #define MSG_SOCK_DEVMEM 0x2000000
>  #endif
>
> -/*
> - * tcpdevmem netcat. Works similarly to netcat but does device memory TCP
> - * instead of regular TCP. Uses udmabuf to mock a dmabuf provider.
> - *
> - * Usage:
> - *
> - *     On server:
> - *     ncdevmem -s <server IP> -c <client IP> -f eth1 -l -p 5201 -v 7
> - *

No need to remove this documentation I think. This is useful since we
don't have a proper docs anywhere.

Please instead update the args in the above line, if they need
updating, but looks like it's already correct even after this change.

> - *     On client:
> - *     yes $(echo -e \\x01\\x02\\x03\\x04\\x05\\x06) | \
> - *             tr \\n \\0 | \
> - *             head -c 5G | \
> - *             nc <server IP> 5201 -p 5201
> - *
> - * Note this is compatible with regular netcat. i.e. the sender or receiver can
> - * be replaced with regular netcat to test the RX or TX path in isolation.
> - */
> -
> -static char *server_ip = "192.168.1.4";
> +static char *server_ip;
>  static char *client_ip;
> -static char *port = "5201";
> +static char *port;
>  static size_t do_validation;
>  static int start_queue = 8;
>  static int num_queues = 8;
> -static char *ifname = "eth1";
> +static char *ifname;
>  static unsigned int ifindex;
>  static unsigned int dmabuf_id;
>
> @@ -613,6 +594,15 @@ int main(int argc, char *argv[])
>                 }
>         }
>
> +       if (!server_ip)
> +               error(1, 0, "Missing -s argument\n");
> +
> +       if (!port)
> +               error(1, 0, "Missing -p argument\n");
> +
> +       if (!ifname)
> +               error(1, 0, "Missing -f argument\n");
> +
>         ifindex = if_nametoindex(ifname);
>
>         for (; optind < argc; optind++)
> --
> 2.46.0
>


-- 
Thanks,
Mina