netdev - RE: [Intel-wired-lan] [PATCH iwl-net v2] ice: Flush FDB entries before reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB50133484C056891F57F38F6A96722@PH0PR11MB5013.namprd11.prod.outlook.com>
Date: Fri, 4 Oct 2024 10:36:19 +0000
From: "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com>
To: "Drewek, Wojciech" <wojciech.drewek@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"marcin.szycik@...ux.intel.com" <marcin.szycik@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"horms@...nel.org" <horms@...nel.org>, "michal.swiatkowski@...ux.intel.com"
	<michal.swiatkowski@...ux.intel.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v2] ice: Flush FDB entries
 before reset

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Wojciech Drewek
> Sent: Friday, September 27, 2024 6:08 PM
> To: netdev@...r.kernel.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> marcin.szycik@...ux.intel.com; intel-wired-lan@...ts.osuosl.org;
> horms@...nel.org; michal.swiatkowski@...ux.intel.com
> Subject: [Intel-wired-lan] [PATCH iwl-net v2] ice: Flush FDB entries before
> reset
> 
> Triggering the reset while in switchdev mode causes errors[1]. Rules are
> already removed by this time because switch content is flushed in case of the
> reset.
> This means that rules were deleted from HW but SW still thinks they exist so
> when we get SWITCHDEV_FDB_DEL_TO_DEVICE notification we try to delete
> not existing rule.
> 
> We can avoid these errors by clearing the rules early in the reset flow before
> they are removed from HW.
> Switchdev API will get notified that the rule was removed so we won't get
> SWITCHDEV_FDB_DEL_TO_DEVICE notification.
> Remove unnecessary ice_clear_sw_switch_recipes.
> 
> [1]
> ice 0000:01:00.0: Failed to delete FDB forward rule, err: -2 ice 0000:01:00.0:
> Failed to delete FDB guard rule, err: -2
> 
> Fixes: 7c945a1a8e5f ("ice: Switchdev FDB events support")
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
> ---
> v2: extend commit msg, add NULL pointer check
> ---
>  .../net/ethernet/intel/ice/ice_eswitch_br.c   |  5 +++-
>  .../net/ethernet/intel/ice/ice_eswitch_br.h   |  1 +
>  drivers/net/ethernet/intel/ice/ice_main.c     | 24 +++----------------
>  3 files changed, 8 insertions(+), 22 deletions(-)
> 
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@...el.com>