netdev - Re: [PATCH bpf-next 1/6] xsk: get rid of xdp_buff_xsk::xskb_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51371534-5813-480f-b797-f073c31df5de@iogearbox.net>
Date: Fri, 4 Oct 2024 14:08:38 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>, bpf@...r.kernel.org,
 ast@...nel.org, andrii@...nel.org
Cc: netdev@...r.kernel.org, magnus.karlsson@...el.com, bjorn@...nel.org
Subject: Re: [PATCH bpf-next 1/6] xsk: get rid of xdp_buff_xsk::xskb_list_node

On 10/2/24 5:54 PM, Maciej Fijalkowski wrote:
> Let's bring xdp_buff_xsk back to occupying 2 cachelines by removing
> xskb_list_node - for the purpose of gathering the xskb frags
> free_list_node can be used, head of the list (xsk_buff_pool::xskb_list)
> stays as-is, just reuse the node ptr.
> 
> It is safe to do as a single xdp_buff_xsk can never reside in two
> pool's lists simultaneously.
> 
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

Given you send v2 anyway, pls also double check the clang errors from netdev CI:
https://netdev.bots.linux.dev/static/nipa/894909/13820003/build_clang/summary