netdev - Re: [PATCH v1 net 4/6] mctp: Handle error of rtnl_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241004010048.30542-1-kuniyu@amazon.com>
Date: Thu, 3 Oct 2024 18:00:48 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuba@...nel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <jk@...econstruct.com.au>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <matt@...econstruct.com.au>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH v1 net 4/6] mctp: Handle error of rtnl_register_module().

From: Jakub Kicinski <kuba@...nel.org>
Date: Thu, 3 Oct 2024 17:39:28 -0700
> On Thu, 3 Oct 2024 13:57:23 -0700 Kuniyuki Iwashima wrote:
> > Since introduced, mctp has been ignoring the returned value
> > of rtnl_register_module(), which could fail.
> > 
> > Let's handle the errors by rtnl_register_module_many().
> > 
> > Fixes: 583be982d934 ("mctp: Add device handling and netlink interface")
> > Fixes: 831119f88781 ("mctp: Add neighbour netlink interface")
> > Fixes: 06d2f4c583a7 ("mctp: Add netlink route management")
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> 
> Build's unhappy about the section markings:
> 
> WARNING: modpost: vmlinux: section mismatch in reference: mctp_init+0xb7 (section: .init.text) -> mctp_neigh_exit (section: .exit.text)

Thanks for catching, will remove __exit from mctp_neigh_exit().

BTW what option is needed to reproduce it ?
I tried W=1 C=1 but didn't see that warning.