netdev - Re: [PATCH v4 net] net: stmmac: dwmac4: extend timeout for VLAN Tag register busy bit check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241004072356.5905e684@kernel.org>
Date: Fri, 4 Oct 2024 07:23:56 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shenwei Wang <shenwei.wang@....com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, horms@...nel.org, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Ong Boon
 Leong <boon.leong.ong@...el.com>, Wong Vee Khee <vee.khee.wong@...el.com>,
 Chuah Kim Tatt <kim.tatt.chuah@...el.com>, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev,
 linux-imx@....com, Serge Semin <fancer.lancer@...il.com>, Andrew Lunn
 <andrew@...n.ch>
Subject: Re: [PATCH v4 net] net: stmmac: dwmac4: extend timeout for VLAN Tag
 register busy bit check

On Tue, 24 Sep 2024 15:54:24 -0500 Shenwei Wang wrote:
> Increase the timeout for checking the busy bit of the VLAN Tag register
> from 10µs to 500ms. This change is necessary to accommodate scenarios
> where Energy Efficient Ethernet (EEE) is enabled.
> 
> Overnight testing revealed that when EEE is active, the busy bit can
> remain set for up to approximately 300ms. The new 500ms timeout provides
> a safety margin.
> 
> Fixes: ed64639bc1e0 ("net: stmmac: Add support for VLAN Rx filtering")
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Shenwei Wang <shenwei.wang@....com>

FTR this was merged to net as commit 4c1b56671b6.