netdev - RE: [Intel-wired-lan] [PATCH v12 iwl-next 2/7] ice: Remove unncecessary ice_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CYYPR11MB84296AF0C6D895037E5FB53ABD722@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Fri, 4 Oct 2024 15:04:55 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Kolacinski, Karol" <karol.kolacinski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v12 iwl-next 2/7] ice: Remove
 unncecessary ice_is_e8xx() functions

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Karol Kolacinski
> Sent: Monday, September 30, 2024 5:43 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Kolacinski, Karol <karol.kolacinski@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH v12 iwl-next 2/7] ice: Remove unncecessary ice_is_e8xx() functions
>
> Remove unnecessary ice_is_e8xx() functions and PHY model. Instead, use MAC type where applicable.
>
> Don't check device type in ice_ptp_maybe_trigger_tx_interrupt(), because in reality it depends on the ready bitmap, which only E810 does not have.
>
> Call ice_ptp_cfg_phy_interrupt() unconditionally, because all further function calls check the MAC type anyway and this allows simpler code in the future with addition of the new MAC types.
>
> Reorder ICE_MAC_* cases in switches in ice_ptp* as in enum ice_mac_type.
>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> ---
> V9 -> V10: Fixed E825C MAC condition in ice_parse_1588_func_caps()
> V8 -> V9: Fixed compilation issue after rebase
> V7 -> V8: Added reordering of ICE_MAC_* cases in switches and explained the rest
>           of previous changes in the commit description
>
>  drivers/net/ethernet/intel/ice/ice.h        |   5 -
>  drivers/net/ethernet/intel/ice/ice_common.c | 120 +----------------
>  drivers/net/ethernet/intel/ice/ice_common.h |   5 -
>  drivers/net/ethernet/intel/ice/ice_ddp.c    |   4 +-
> drivers/net/ethernet/intel/ice/ice_ptp.c    | 137 +++++++++----------
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 138 ++++++++++----------  drivers/net/ethernet/intel/ice/ice_ptp_hw.h |  20 +--
>  drivers/net/ethernet/intel/ice/ice_type.h   |   9 --
>  8 files changed, 155 insertions(+), 283 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)