netdev - Re: [PATCH net-next 1/2] Convert neighbour-table to use hlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241004150606.3968051-1-gnaaman@drivenets.com>
Date: Fri,  4 Oct 2024 15:06:06 +0000
From: Gilad Naaman <gnaaman@...venets.com>
To: horms@...nel.org
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	gnaaman@...venets.com,
	kuba@...nel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com
Subject: Re: [PATCH net-next 1/2] Convert neighbour-table to use hlist

Hey Simon,

Thank you for the notes, I'll make sure that Sparse is happy.

For some reason I can't get it to accept `hlist_for_each_entry_rcu`,
complaining that the cast removes `__rcu`, (even if I add `__rcu` to the
`pos` variable definition):


 > static int neigh_dump_table(struct neigh_table *tbl, struct sk_buff *skb,
 > 			    struct netlink_callback *cb,
 > 			    struct neigh_dump_filter *filter)
 > {
 > 	struct net *net = sock_net(skb->sk);
 > 	struct neighbour __rcu *n;

<snip>

Line 2752:
 > 		hlist_for_each_entry_rcu(n, &nht->hash_buckets[h], list) {

Sparse output:
 > net/core/neighbour.c:2752:17: sparse: warning: cast removes address space '__rcu' of expression

Do you know if this is solveable without reverting to the previous style
of iteration?

Thank you