netdev - Re: [PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241004094314.735bb69c@kernel.org>
Date: Fri, 4 Oct 2024 09:43:14 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: idosch@...dia.com, aleksander.lobakin@...el.com, horms@...nel.org,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 dsahern@...nel.org, dongml2@...natelecom.cn, amcohen@...dia.com,
 gnault@...hat.com, bpoirier@...dia.com, b.galvani@...il.com,
 razor@...ckwall.org, petrm@...dia.com, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 03/12] net: tunnel: add
 skb_vlan_inet_prepare_reason() helper

On Tue,  1 Oct 2024 15:32:16 +0800 Menglong Dong wrote:
> -static inline bool skb_vlan_inet_prepare(struct sk_buff *skb,
> -					 bool inner_proto_inherit)
> +static inline enum skb_drop_reason
> +skb_vlan_inet_prepare_reason(struct sk_buff *skb, bool inner_proto_inherit)

this only has 5 callers, please convert them to expect a drop
reason to be returned instead of adding a compatibility wrapper
-- 
pw-bot: cr