netdev - Re: [PATCHv2 5/5] documentation: use nvmem-layout in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKxU2N9-DxfsANMfT8DZ-LuKJ3bqjckyfd=+Lg_qtRn985BuoQ@mail.gmail.com>
Date: Fri, 4 Oct 2024 12:04:26 -0700
From: Rosen Penev <rosenp@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: devicetree@...r.kernel.org, Miquel Raynal <miquel.raynal@...tlin.com>, 
	Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	William Zhang <william.zhang@...adcom.com>, Anand Gore <anand.gore@...adcom.com>, 
	Kursad Oney <kursad.oney@...adcom.com>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Rafał Miłecki <rafal@...ecki.pl>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>, 
	Gregory Clement <gregory.clement@...tlin.com>, 
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Christian Marangi <ansuelsmth@...il.com>, 
	"open list:MEMORY TECHNOLOGY DEVICES (MTD)" <linux-mtd@...ts.infradead.org>, open list <linux-kernel@...r.kernel.org>, 
	"open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>, 
	"open list:ARM/QUALCOMM MAILING LIST" <linux-arm-msm@...r.kernel.org>, 
	"moderated list:BROADCOM BCMBCA ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, 
	"moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCHv2 5/5] documentation: use nvmem-layout in examples

On Thu, Oct 3, 2024 at 11:25 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 04/10/2024 02:00, Rosen Penev wrote:
> > nvmem-cells are deprecated and replaced with nvmem-layout. For these
> > examples, replace. They're not relevant to the main point of the
> > document anyway.
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
>
> >
> > Signed-off-by: Rosen Penev <rosenp@...il.com>
> > ---
> >  .../mtd/partitions/qcom,smem-part.yaml        | 19 +++++++++++--------
> >  .../bindings/net/marvell,aquantia.yaml        | 13 ++++++++-----
> >  2 files changed, 19 insertions(+), 13 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml
> > index 1c2b4e780ca9..8ae149534b23 100644
> > --- a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml
> > @@ -45,17 +45,20 @@ examples:
> >              compatible = "qcom,smem-part";
> >
> >              partition-art {
> > -                compatible = "nvmem-cells";
> > -                #address-cells = <1>;
> > -                #size-cells = <1>;
> >                  label = "0:art";
> >
> > -                macaddr_art_0: macaddr@0 {
> > -                    reg = <0x0 0x6>;
> > -                };
> > +                nvmem-layout {
> > +                    compatible = "fixed-layout";
>
> This does not look right - the binding still expects nvmem-cells. I
> wonder how does the nvmem-cells.yaml work if the compatible is being
> removed so it is not being selected.
Not sure I follow here. You mean replace nvmem-cells.yaml with
nvmem-layout.yaml ?
>
>
> Best regards,
> Krzysztof
>