netdev - Re: [PATCH v4 net-next 0/7] sfc: per-queue stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <568e83fb-ba49-4998-9245-7353ae2cb563@intel.com>
Date: Fri, 4 Oct 2024 15:37:17 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: <edward.cree@....com>, <linux-net-drivers@....com>, <davem@...emloft.net>,
	<kuba@...nel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>
CC: Edward Cree <ecree.xilinx@...il.com>, <netdev@...r.kernel.org>,
	<habetsm.xilinx@...il.com>
Subject: Re: [PATCH v4 net-next 0/7] sfc: per-queue stats



On 9/30/2024 6:52 AM, edward.cree@....com wrote:
> From: Edward Cree <ecree.xilinx@...il.com>
> 
> This series implements the netdev_stat_ops interface for per-queue
>  statistics in the sfc driver, partly using existing counters that
>  were originally added for ethtool -S output.
> 
> Changed in v4:
> * remove RFC tags
> 
> Changed in v3:
> * make TX stats count completions rather than enqueues
> * add new patch #4 to account for XDP TX separately from netdev
>   traffic and include it in base_stats
> * move the tx_queue->old_* members out of the fastpath cachelines
> * note on patch #6 that our hw_gso stats still count enqueues
> * RFC since net-next is closed right now
> 
> Changed in v2:
> * exclude (dedicated) XDP TXQ stats from per-queue TX stats
> * explain patch #3 better
> 
> Edward Cree (7):
>   sfc: remove obsolete counters from struct efx_channel
>   sfc: implement basic per-queue stats
>   sfc: add n_rx_overlength to ethtool stats
>   sfc: account XDP TXes in netdev base stats
>   sfc: implement per-queue rx drop and overrun stats
>   sfc: implement per-queue TSO (hw_gso) stats
>   sfc: add per-queue RX bytes stats
> 
The whole series looks good to me, thanks!

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>