netdev - Re: [PATCH net v2] net: dsa: lan9303: ensure chip reset and wait for READY status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4e0dba3867bc16f6c0a26f2767e559d5a4156fe.camel@siemens.com>
Date: Fri, 4 Oct 2024 07:26:21 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "olteanv@...il.com" <olteanv@...il.com>
CC: "agust@...x.de" <agust@...x.de>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "f.fainelli@...il.com" <f.fainelli@...il.com>,
	"andrew@...n.ch" <andrew@...n.ch>
Subject: Re: [PATCH net v2] net: dsa: lan9303: ensure chip reset and wait for
 READY status

Thanks for the review Vladimir!

On Fri, 2024-10-04 at 00:15 +0300, Vladimir Oltean wrote:
> > +	 * switch's reading of EEPROM right after reset and this behaviour is
> > +	 * not configurable. While lan9303_read() already has quite long retry
> > +	 * timeout, seems not all cases are being detected as arbitration error.
> 
> These arbitration errors happen only after reset? So in theory, after
> this patch, we could remove the for() loop from lan9303_read()?

This is a good point! Shall I add the removal to a series for net or post the
removal separately for net-next?

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com